$ variable sigil support - #44
Merged
Merged
Conversation
cliffcaseyyet
approved these changes
Aug 20, 2026
quoll
reviewed
Aug 20, 2026
| scope (set (mapcat vv/get-scope-vars prev-elems))] | ||
| (when (contains? scope bind-var) | ||
| scope (set (mapcat vv/get-scope-vars prev-elems)) | ||
| scope-names (set (map p/variable-name scope))] |
There was a problem hiding this comment.
Creating a set for scope is extra work for no reason.
Could use:
(->> prev-elems
(mapcat vv/get-scope-vars)
(map p/variable-name)
set)Or via transducing:
(into #{}
(comp (mapcat vv/get-scope-vars)
(map p/variable-name))
prev-elems)(yes, I saw this is merged, sorry)
Member
Author
There was a problem hiding this comment.
Yep, you're totally right, I was rushing. I'll fix that up, thanks!
Member
Author
There was a problem hiding this comment.
Actually looking at this again I think perhaps the intermediate set was mainly for the error output (I just kind of followed @kelvinqian00's lead there), but the set part of that doesn't actually have to happen until we make the error below
quoll
reviewed
Aug 20, 2026
| scope (set (concat where-vars group-vars prev-vars))] | ||
| (if-some [bad-expr-vars (not-empty (filter #(not (scope %)) expr-vars))] | ||
| scope (set (concat where-vars group-vars prev-vars)) | ||
| scope-names (set (map p/variable-name scope))] |
There was a problem hiding this comment.
Again, scope is only used to construct the scope-names set, and need not be a set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #42 we should support the
$variablesigil in addition to the?variableone we already know. Additionally?abcand$abcrefer to the same variable.